Re: pgsql: Add compat file for dynamically loading the functions that MinGW

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Add compat file for dynamically loading the functions that MinGW
Дата
Msg-id 5019.1193666044@sss.pgh.pa.us
обсуждение исходный текст
Ответ на pgsql: Add compat file for dynamically loading the functions that MinGW  (mha@postgresql.org (Magnus Hagander))
Ответы Re: pgsql: Add compat file for dynamically loading the functions that MinGW  (Magnus Hagander <magnus@hagander.net>)
Список pgsql-committers
mha@postgresql.org (Magnus Hagander) writes:
> Add compat file for dynamically loading the functions that MinGW is missing
> the imports for. Add RegisterWaitForSingleObject() to the list of such
> functions, which should take care of the current buildfarm breakage.

Trivial stylistic complaint: shouldn't the _RegisterWaitForSingleObject
variable be declared static?  IMHO variables (and functions) should
always be static unless there is an explicit intent to access them from
other modules.

            regards, tom lane

В списке pgsql-committers по дате отправления:

Предыдущее
От: teodor@postgresql.org (Teodor Sigaev)
Дата:
Сообщение: pgsql: Fix coredump during replay WAL after crash.
Следующее
От: Magnus Hagander
Дата:
Сообщение: Re: pgsql: Add compat file for dynamically loading the functions that MinGW