On 08/19/2013 07:35 PM, Noah Misch wrote:
> That was option #1. (You weren't planning to change just the one symbol
> causing the failure at hand, were you?) Reasonable choice. The point in the
> code comment quoted above looks bad, but the lack of reports of that nature
> against official 9.2 binaries corroborates it having not been a problem yet.
> The only non-socket use I see for the constants in question is the EINTR test
> in XLogWrite(), which probably can't happen on Windows.
Redefining compiler constants is bad bandaid. A similar bandaid was in
place to begin with caused this problem. If you believe PostgreSQL will
never use code that needs the true errno value then go ahead with Option 1.
> Ah; true enough.
After looking over the changes it was a merge mistake. I originally
wrote the patch on the 9.2 branch and ported it to master. Nothing to
call "misguided".
Just so that everyone understands: I was looking for comments to discuss
a solution to the socket error checking problem. I'm not looking to
shove anything down one's throat.