Re: Rationalizing code-sharing among src/bin/ directories

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Rationalizing code-sharing among src/bin/ directories
Дата
Msg-id 5246.1458837594@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Rationalizing code-sharing among src/bin/ directories  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Список pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Tom Lane wrote:
>> This name is a bit arbitrary, but most of what's there is string
>> processing of some flavor or other, with some list processing thrown
>> in for good measure.  If anyone's got a different color to paint this
>> bikeshed, please speak up.

> I wondered about the list stuff while messing about in pg_dump awhile
> ago.  It seems moderately okay, but not terribly generic; maybe we
> should get rid of all that stuff and make ilist.c available to frontend.
> Not sure how easy is that, given that AFAIR ilist uses elog.  Anyway
> maybe we can discuss that in the future, to avoid blocking your patch.

It wouldn't be terribly hard to split the file into, say, string_utils
and simple_list files.  On reflection that seems like a good idea as
long as we're going for cleanup rather than a one-to-one rename.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: VS 2015 support in src/tools/msvc
Следующее
От: "Matt Wilmas"
Дата:
Сообщение: Re: btree_gin and btree_gist for enums