(2014/11/17 19:54), Ashutosh Bapat wrote:
> Here are comments for postgres_fdw-syscol patch.
Thanks for the review!
> Code
> -------
> 1. Instead of a single liner comment "System columns can't be sent to
> remote.", it might be better to explain why system columns can't be sent
> to the remote.
Done.
> 2. The comment in deparseVar is single line comment, so it should start
> and end on the same line i.e. /* and */ should be on the same line.
Done.
> 3. Since there is already a testcase which triggered this particular
> change, it will good, if we add that to regression in postgres_fdw.
Done.
Please find attached an updated version of the patch.
Thanks,
Best regards,
Etsuro Fujita