On 04/03/15 08:57, Tom Lane wrote:
> Josh Berkus <josh@agliodbs.com> writes:
>> Do we want to remove unit comments from all settings which accept
>> "MB,GB" or "ms,s,min"? There's more than a few. I'd be in favor of
>> this, but seems like (a) it should be universal, and (b) its own patch.
> Meh. Doing this strikes me as a serious documentation failure, since it
> is no longer apparent what happens if you put in a unitless number.
>
> Now, if we were to change the server so that it *refused* settings that
> didn't have a unit, that argument would become moot. But I'm not going
> to defend the castle against the villagers who will show up if you do
> that.
>
> regards, tom lane
>
>
How about introducing a 'strict' mode that does extra checking like that?
JavaScript and Perl, both have a 'strict' mode.
In strict mode you could insist on all quantities having units, and
possibly some additional sanity checking - without enraging the peasants!
Cheers,
Gavin