On 2015/10/29 23:22, Syed, Rahila wrote:
>
> Please find attached an updated patch.
>
Thanks for the v6. A few quick comments:
- duplicate_oids error in HEAD.
- a compiler warning:
pgstat.c:2898: warning: no previous prototype for ‘pgstat_reset_activityflag’
To fix that use void for empty parameter list -
-extern void pgstat_reset_activityflag();
+extern void pgstat_reset_activityflag(void);
One more change you could do is 's/activityflag/activity_flag/g', which I
guess is a naming related guideline in place.
Thanks,
Amit