Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4

Поиск
Список
Период
Сортировка
От Chapman Flack
Тема Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4
Дата
Msg-id 592E5ABF.8070706@anastigmatix.net
обсуждение исходный текст
Ответ на Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 05/31/17 01:26, Tom Lane wrote:
> Hm.  I think it would be better to use DatumGetInt32 here.  Arguably,
> direct use of GET_4_BYTES and its siblings should only appear in
> DatumGetFoo macros.

Like so? These are the 4 sites where {GET,SET}_n_BYTES got introduced
in 14cca1b (for consistency, though only the GET_4 case produces warnings).

-Chap

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4