Hi,
Thank you, Jian, for nice comments!
PFA version with your recommendations.
Andrey,
I didn't yet check your patches, but at least compiler complains about added, but unused variable "miss_oversized_tuple".
verify_nbtree.c:2898:7: warning: unused variable 'miss_oversized_tuple' [-Wunused-variable]
bool miss_oversized_tuple = false;
So patch has been updated to fix this warning.
Attached v4, rebased version with Jian's comments & removed unused variable.
Thanks,
Michael.
On 1/23/24 21:09, Andrey M. Borodin wrote:
On 20 Jan 2024, at 09:00, Alexander Lakhin <exclusion@gmail.com> wrote:
Alexander, do you plan to provide fixes for bugs you discovered?
No, I don't have a concrete proposal how to fix those bugs. I'd thought
that fixing the whole class of such anomalies, not only one case, is a good
thing to do, but if it's too complicated, maybe other similar bugs could be
put aside.
PFA draft fixes for both this errors. Alexander, Michael, Jian, what do you think?
I did not touch anything in first step - fix for original bug in this thread. However, I think that comments from Jian He worth incorporating into the fix.
Best regards, Andrey Borodin.
--
Michael Zhilin
Postgres Professional
+7(925)3366270
https://www.postgrespro.ru