Re: pgsql: Skip \password TAP test on old IPC::Run versions

Поиск
Список
Период
Сортировка
От Andrew Dunstan
Тема Re: pgsql: Skip \password TAP test on old IPC::Run versions
Дата
Msg-id 6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net
обсуждение исходный текст
Ответ на pgsql: Skip \password TAP test on old IPC::Run versions  (Daniel Gustafsson <dgustafsson@postgresql.org>)
Ответы Re: pgsql: Skip \password TAP test on old IPC::Run versions  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-committers


On 2023-04-08 Sa 09:57, Daniel Gustafsson wrote:
Skip \password TAP test on old IPC::Run versions

IPC::Run versions prior to 0.98 cause the interactive session to time out,
so SKIP the test in case these versions are detected (they are within the
base requirement for our TAP tests in general).  Error reported by the BF
and investigation by Tom Lane.

Discussion: https://postgr.es/m/414A86BD-986B-48A7-A1E4-EEBCE5AF08CB@yesql.se


Stylistic nitpick: It's not necessary to have 2 evals here:


+   skip "IO::Pty and IPC::Run >= 0.98 required", 1 unless
+       (eval { require IO::Pty; } && eval { $IPC::Run::VERSION >= '0.98' });


just say "eval { require IO::Pty; return $IPC::Run::VERSION >= '0.98'; }"


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

В списке pgsql-committers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: pgsql: Try to unbreak MSVC builds for pg_waldump
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Improve indentation of multiline initialization expressions.