Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.

Поиск
Список
Период
Сортировка
От Tomas Vondra
Тема Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.
Дата
Msg-id 77ac2e24-051b-d57a-b02e-4dbc3306f895@enterprisedb.com
обсуждение исходный текст
Ответ на Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-committers

On 11/6/21 15:30, Tom Lane wrote:
> Peter Geoghegan <pg@bowt.ie> writes:
>> On Fri, Nov 5, 2021 at 7:30 AM Robert Haas <rhaas@postgresql.org> wrote:
>>> Introduce 'bbstreamer' abstraction to modularize pg_basebackup.
> 
>> I'm seeing a pretty straightforward looking compiler warning following
>> this commit:
>> bbstreamer_file.c:564:24: warning: unused variable ‘mystreamer’
> 
> And apparently, that file isn't getting built at all on the MSVC side:
> 
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2021-11-06%2003%3A52%3A19
> 

I got annoyed by the warning so I marked the variable as assert-only. 
Haven't done anything about the MSVC issue.

regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



В списке pgsql-committers по дате отправления:

Предыдущее
От: Tomas Vondra
Дата:
Сообщение: pgsql: Add bool GiST opclass to btree_gist
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Un-break pg_basebackup's MSVC build.