Liam Stewart <liams@redhat.com> writes:
>> How would you feel about quoting only if necessary
>> (cf. quote_identifier)?
> That would work nicely. I didn't put the call to quote_identifier inside
> the stringStringInfo macro.
Actually, stringStringInfo seems entirely pointless here; the result of
RelationGetRelationName can't be NULL. The other places where it's
being used seem pointless as well. I removed it while applying your
patch...
regards, tom lane