> One thing that first pops out to me is that we can do the refactor of
> hash_initial_lookup() as an independent piece, without the extra paths
> introduced. But rather than returning the bucket hash and have the
> bucket number as an in/out argument of hash_initial_lookup(), there is
> an argument for reversing them: hash_search_with_hash_value() does not
> care about the bucket number.
Ok, no problem
>
>> 02-hash_seq_init_with_hash_value.v5.patch - introduces a
>> hash_seq_init_with_hash_value() method. hash_initial_lookup() is marked as
>> inline, but I suppose, modern compilers are smart enough to inline it
>> automatically.
>
> Likely so, though that does not hurt to show the intention to the
> reader.
Agree
>
> So I would like to suggest the attached patch for this first piece.
> What do you think?
I have not any objections
>
> It may also be an idea to use `git format-patch` when generating a
> series of patches. That makes for easier reviews.
Thanks, will try
--
Teodor Sigaev E-mail: teodor@sigaev.ru
WWW: http://www.sigaev.ru/