On Wed, Jun 8, 2011 at 8:52 AM, Federico Di Gregorio
<federico.digregorio@dndg.it> wrote:
> yesterday I had a good look at all the code and every single change
> seems fine to me. I merged everything but there is a little quirk: I see
> that you're using lower case for SQL keywords like the transaction
> levels while the PostgreSQL preferred lettering is uppercase (just have
> a look at the manuals). I think it would be better to just be coherent
> with PostgreSQL documentation.
Do you mean in the python interface or internally? Or in the docs?
FWIW for isolevel values I've take the lettering from the effectively
stored values of the GUC, e.g. SHOW default_isolation_level gives
"serializable" even if you set it uppercode (however they are parsed
non case sensitive, just to be sure). The values accepted by the
python set_transaction() are not case sensitive, and I've preferred
documenting them lowercase because it's easier to type and doesn't
feel "alien" in python code.
But more likely I've not understood what you are referring to :)
> Also waiting on Jason+Stephen for any windows fix before the release.
Finished a few minutes ago to verify their changes, both on linux and
on mingw. The seup cleanup branch is merged in my devel now.
-- Daniele