Re: warnings patch submission

On Fri, Jul 19, 2013 at 2:58 PM, Richard PALO <richard.palo@baou.fr> wrote:
> The following patch should get over the (in this case cosmetic) warning:
>>
>> ./gqb/gqbView.cpp: In member function 'void
>> gqbView::onMotion(wxMouseEvent&)':
>> ./gqb/gqbView.cpp:344:16: warning: converting 'false' to pointer type
>> 'gqbObject*' [-Wconversion-null]
>>     anySelected = false;
>>                 ^
>
>
>
> diff --git a/pgadmin/gqb/gqbView.cpp b/pgadmin/gqb/gqbView.cpp
> index 3afe4c8..9d5bab6 100644
> --- a/pgadmin/gqb/gqbView.cpp
> +++ b/pgadmin/gqb/gqbView.cpp
> @@ -341,7 +341,7 @@ void gqbView::onMotion(wxMouseEvent &event)
>                 }
>                 else
>                 {
> -                       anySelected = false;
> +                       anySelected = NULL;
>                         mode = pt_normal;
>                 }

Thanks - applied. I also cherry-picked all three of your patches to
the 1.16 branch. We probably won't do another release from that, but
it's there if you need it.

>
> ==================================================================
> On the other hand, the maintainer may wish to take a look at the following
> warnings in pgadmin/ogl/drawn.cpp:
>
>> ./ogl/drawn.cpp: In member function 'virtual void wxOpSetGDI::Do(wxDC&,
>> double, double)':
>> ./ogl/drawn.cpp:423:53: warning: cast to pointer from integer of different
>> size [-Wint-to-pointer-cast]
>>     if (m_image->m_outlineColours.Member((wxObject *)m_gdiIndex))
>>                                                      ^
>> ./ogl/drawn.cpp:444:53: warning: cast to pointer from integer of different
>> size [-Wint-to-pointer-cast]
>>     if (m_image->m_outlineColours.Member((wxObject *)m_gdiIndex))
>>                                                      ^
>> ./ogl/drawn.cpp:454:55: warning: cast to pointer from integer of different
>> size [-Wint-to-pointer-cast]
>>     else if (m_image->m_fillColours.Member((wxObject *)m_gdiIndex))
>>                                                        ^
>> ./ogl/drawn.cpp: In member function 'virtual void
>> wxPseudoMetaFile::SetPen(wxPen*, bool)':
>> ./ogl/drawn.cpp:2443:46: warning: cast to pointer from integer of
>> different size [-Wint-to-pointer-cast]
>>    m_outlineColours.Append((wxObject *) (n - 1));
>>                                               ^
>> ./ogl/drawn.cpp: In member function 'virtual void
>> wxPseudoMetaFile::SetBrush(wxBrush*, bool)':
>> ./ogl/drawn.cpp:2458:43: warning: cast to pointer from integer of
>> different size [-Wint-to-pointer-cast]
>>    m_fillColours.Append((wxObject *) (n - 1));
>>                                            ^

Hmm, yeah - those files were inherited from wxOGL which was
deprecated. We've avoided touching them so far as none of us is really
familiar with that code. Guess we might have to dig in sometime.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company