Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node
Дата
Msg-id CA+OCxoyAggOaNRdYLmOQtHsSq4eNWiu-FbvCfnTyLVbTehD1=Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Ответы Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Hi

Hmm, OK - well I still can't reproduce it (using a table), but the change is clearly an appropriate check so I'll get it committed.

Thanks.

On Mon, May 15, 2017 at 9:53 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

As there were no proper steps given in RM to re-produce the issue, I assumed that user tried to delete schema and then click on the table, hence he got that error.
So I checked the code notice that validation was missing at a location of error trace mentioned in RM, it assumed that we always get one row from database. 



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Mon, May 15, 2017 at 1:57 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, May 15, 2017 at 7:14 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to add object validation in table node for SQL and Properties tab .
RM#2395

I don't see how this relates to the issue reported which is related to dropping a schema containing a view (from what I can tell), whereas the patch is changing the table module. 

FWIW, I can't reproduce the reported issue either.

Can you clarify please?
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Harshal Dhumal
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename
Следующее
От: Dave Page
Дата:
Сообщение: [pgadmin-hackers] pgAdmin 4 commit: Validate table presence in SQL and Properties routeh