Re: Regarding feature #6841

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: Regarding feature #6841
Дата
Msg-id CA+OCxoz30kYxbska9TFHDKO3kXoervwY6OYE2kcY6b-k6-iYvg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Regarding feature #6841  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Ответы Re: Regarding feature #6841  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Список pgadmin-hackers
Hi

On Fri, 19 Apr 2024 at 11:56, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Even if you put the cursor on the "SELECT"? If so, that would imply the parser understands the string quoting; e.g. in this case, the Python multiline string. Presumably then it would also understand regular single and double quotes - what about (for example) a heredoc in a pl/sh function?
Yes, the parser understands all the aspects of a SQL query and so it understands what type of token the cursor is based on which it does the syntax highlighting I believe.

Does it? Even EPAS extensions?

 

It sounds like Thom has similar concerns, and I know him well enough to know he wouldn't chime in without good reason.
There are limitations and it won't work correctly apart from standard SQL queries. Like I said, we're adding it as a new button without touching the existing working. If a user chooses to use the new button, he knows that pgAdmin will try to find the query on its own. This is an optional feature.
Additionally, what we could do is when the user hits the button we will show a warning and the user can opt for not showing it again.

Ten minutes later they will have forgotten that warning.

I'm currently thinking that we should display the current query all the time somehow (though I'm not sure how, without taking up a lot of space).

BTW, if we do figure out a way of doing this that we all agree is safe, I'm going to want to see a bunch of automated tests against valid EPAS and PG queries, as weird and bizarre as we can think of.

--

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Aditya Toshniwal
Дата:
Сообщение: Re: Regarding feature #6841
Следующее
От: Aditya Toshniwal
Дата:
Сообщение: Re: Regarding feature #6841