On Mon, Jan 23, 2023 at 8:31 AM James Coleman <jtc331@gmail.com> wrote:
> See the attached for a simple comment fix -- the referenced
> generate_useful_gather_paths call isn't in grouping_planner it's in
> apply_scanjoin_target_to_paths.
The intended reading of the comment is not clear. Is it telling you to
look at grouping_planner because that's where we
generate_useful_gather_paths, or is it telling you to look there to
see how we get the final target list together? If it's the former,
then your fix is correct. If the latter, it's fine as it is.
The real answer is probably that some years ago both things happened
in that function. We've moved on from there, but I'm still not sure
what the most useful phrasing of the comment is.
--
Robert Haas
EDB: http://www.enterprisedb.com