Re: Is this a problem in GenericXLogFinish()?

On Mon, Nov 13, 2023 at 12:47 AM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
> Moved.

I see that this patch was committed, but I'm not very convinced that
the approach is correct. The comment says this:

+           /*
+            * A write buffer needs to be registered even if no tuples are
+            * added to it to ensure that we can acquire a cleanup lock on it
+            * if it is the same as primary bucket buffer or update the
+            * nextblkno if it is same as the previous bucket buffer.
+            */

But surely if the buffer is the same as one of those others, then it's
registered anyway, and if it isn't, then it doesn't need to be.

--
Robert Haas
EDB: http://www.enterprisedb.com