Re: RecoveryInProgress() has critical side effects

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: RecoveryInProgress() has critical side effects
Дата
Msg-id CA+Tgmobrw_+7F5JmYQP4u4sZRqE1MExPFGMAOuA-TfW1=NghJA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: RecoveryInProgress() has critical side effects  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: RecoveryInProgress() has critical side effects  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Дерево обсуждения 
On Sat, Dec 4, 2021 at 7:44 PM Michael Paquier <michael@paquier.xyz> wrote:
> My main worry here is that this changes slightly the definition of
> doPageWrites across stable branches at the end of recovery as there
> could be records generated there.  Note that GetFullPageWriteInfo()
> gets called in XLogInsert(), while Insert->fullPageWrites gets updated
> before CleanupAfterArchiveRecovery().  And it may influence
> the value of doPageWrites in the startup process.

But ... so what? All the code that uses it retries if the value that
was tentatively used turns out to be wrong.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Bossart, Nathan"
Дата:
Сообщение: Re: Should we improve "PID XXXX is not a PostgreSQL server process" warning for pg_terminate_backend(<>)?
Следующее
От: Peter Geoghegan
Дата:
Сообщение: Re: Why doesn't pgstat_report_analyze() focus on not-all-visible-page dead tuple counts, specifically?