[pgadmin-hackers][patch] Make feature test app teardown morereliable, and tests faster

Поиск
Список
Период
Сортировка
От Atira Odhner
Тема [pgadmin-hackers][patch] Make feature test app teardown morereliable, and tests faster
Дата
Msg-id CA+Vc24pqpVFJL-VNsk_CpGgGHBf6-EGNkcymXUTxHq5N96HQ-A@mail.gmail.com
обсуждение исходный текст
Ответы Re: [pgadmin-hackers][patch] Make feature test app teardown morereliable, and tests faster  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers

Hi Hackers,

We made the following improvements to the test suite:

Make feature test app teardown more reliable, and tests faster

    - don't spin up app and chromedriver between each test
    - catching signals also tears down the app
    - do layout reset between tests, but assume that tests will not leave a modal opened.

 Use selenium built-in waiting function and fix flakiness around clicking the alertify OK button

    - we think the OK button does not have its event bound when it is created.

If you see more flakiness around clicking the alertify OK button, let us know. The element is clickable but we have to arbitrarily wait for the event to be bound and that timing may vary system to system.

The feature tests are about 7 seconds faster now.

Tira & Joao

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgadmin-hackers][patch] Use TEST_SQLITE_PATH for tests
Следующее
От: Dave Page
Дата:
Сообщение: [pgadmin-hackers] pgAdmin 4 commit: Ignore Visual Studio code editor files.