> On Thu, Oct 25, 2018 at 11:19 PM Dmitry Dolgov <9erthalion6@gmail.com> wrote:
>
> Since most of my complaints about the patch were related to code readability,
> I modified it a bit to show more clearly what I have in mind. I haven't changed
> anything about the functionality, just adjusted some parts of it:
>
> * removed some unused arguments (looks like they were added for consistency in
> all higher level branches, but not all of them were actually in use)
>
> * replaced representation for partition mapping (instead of int arrays there is
> a structure, that allows to replace 0/1 with more meaningful from/to)
>
> * tried to make naming a bit more consistent - so, if a function doesn't
> explicitely say anything about outer/inner, we have partmap1/partmap2,
> otherwise outermap/innermap. I don't really like this style with
> partmap1/partmap2 or index1/index2, but it seems consistent with the rest of
> the code in partbounds.c
>
> * removed some state representation flags, e.g. merged - instead, if there is a
> situation when we can't merge, functions will return NULL right away
>
> * removed questionable debugging statement
I've noticed, that this patch set is outdated, so here is the rebased version.