Re: [PATCH] Add Commit/Rollback toolbar action

Thanks,

I can try to look at disabling when not in transaction mode + the short cuts.

Regarding the icons, toad for oracle uses a database icon which the arrows point to/from. Perhaps we should add something *similar*?

-- john

2015-06-17 13:44 GMT+02:00 Sanket Mehta <sanket.mehta@enterprisedb.com>:

Hi John,

I have applied the patch and below are my suggestions:

1. Rollback and commit icons should be disabled session is not in transaction mode

2. Rollback and Commit should also be included in Query menu and individual short cut should be assigned to them.

Dave,

Can we have any other icons for both the functionality as these icons looks odd to me.

Regards,

Sanket Mehta

Sr Software engineer

Enterprisedb

On Tue, Jun 16, 2015 at 5:03 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:

Sure Dave.

Regards,

Sanket Mehta

Sr Software engineer

Enterprisedb

On Tue, Jun 16, 2015 at 4:55 PM, Dave Page <dpage@pgadmin.org> wrote:

Sanket, can you look at this please?

Sent from my iPad

> On 15 Jun 2015, at 16:33, John Obaterspok <john.obaterspok@gmail.com> wrote:
>
> Hello,
>
> With the newly added option to disable auto commit (hurray) I really missed commit/rollback toolbar buttons. Attached patch adds this.
>
> -- john
>

> <0001-Add-Commit-Rollback-toolbar-action.patch>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers