Re: [PATCH] Fix crash when disabling auto commit

Поиск
Список
Период
Сортировка
От Sanket Mehta
Тема Re: [PATCH] Fix crash when disabling auto commit
Дата
Msg-id CA+yw=mNK+hy2rCA0-X3S37pXejt_srt1i7_zNhNKMMC0xF6npA@mail.gmail.com
обсуждение исходный текст
Ответ на [PATCH] Fix crash when disabling auto commit  (John Obaterspok <john.obaterspok@gmail.com>)
Ответы Re: [PATCH] Fix crash when disabling auto commit  (Sanket Mehta <sanket.mehta@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi,

I am looking into the same and few other issues in code and will send the patch soon.


Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, Jun 12, 2015 at 1:49 AM, John Obaterspok <john.obaterspok@gmail.com> wrote:
Fix crash when string has only alphas (like 'rollback')

diff --git a/pgadmin/frm/frmQuery.cpp b/pgadmin/frm/frmQuery.cpp
index b5a2f56..110bbc7 100644
--- a/pgadmin/frm/frmQuery.cpp
+++ b/pgadmin/frm/frmQuery.cpp
@@ -2522,7 +2522,7 @@ bool frmQuery::isBeginNotRequired(wxString query)
  /*
  * Check word length (since "beginx" is not "begin").
  */
- while(wxIsalpha(query.GetChar(wordlen)))
+ while(wordlen < query.Length() && wxIsalpha(query.GetChar(wordlen)))
  wordlen++;
 
  /*

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Ashesh Vashi
Дата:
Сообщение: Re: [PATCH] Add ElapsedTimeToString to format execution time in a more readable manner (instead of showing everything as msec)
Следующее
От: Sanket Mehta
Дата:
Сообщение: Re: [PATCH] Fix crash when disabling auto commit