On Thu, Feb 15, 2024 at 11:49 AM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
>
> At Thu, 15 Feb 2024 09:22:23 +0530, shveta malik <shveta.malik@gmail.com> wrote in
> >
> > +1 on changing the msg(s) suggested way. Please find the patch for the
> > same. It also removes double quotes around the variable names
>
> Thanks for the discussion.
>
> With a translator hat on, I would be happy if I could determine
> whether a word requires translation with minimal background
> information. In this case, a translator needs to know which values
> wal_level can take. It's relatively easy in this case, but I'm not
> sure if this is always the case. Therefore, I would be slightly
> happier if "logical" were double-quoted.
>
I see that we use "logical" in double quotes in various error
messages. For example: "wal_level must be set to \"replica\" or
\"logical\" at server start". So following that we can use the double
quotes here as well.
--
With Regards,
Amit Kapila.