Re: Explain [Analyze] produces parallel scan for select Into table statements.

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: Explain [Analyze] produces parallel scan for select Into table statements.
Дата
Msg-id CAA4eK1+n03Gg_c5wnY_BJ=U+uiNJvbaZqf2dyDE8tWzg+uirJw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Explain [Analyze] produces parallel scan for select Into table statements.  (Mithun Cy <mithun.cy@enterprisedb.com>)
Ответы Re: Explain [Analyze] produces parallel scan for select Into table statements.  (Mithun Cy <mithun.cy@enterprisedb.com>)
Re: Explain [Analyze] produces parallel scan for select Into table statements.  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
On Fri, Mar 11, 2016 at 3:34 PM, Mithun Cy <mithun.cy@enterprisedb.com> wrote:
>
> On Thu, Mar 10, 2016 at 9:39 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> >I guess there must not be an occurrence of this pattern in the
> >regression tests, or previous force_parallel_mode testing would have
> >found this problem.  Perhaps this patch should add one?
>
> I have added the test to select_into.sql. Added Explain select into statement.
>

I don't see how this test will fail with force_parallel_mode=regress and max_parallel_degree > 0 even without the patch proposed to fix the issue in hand.  In short, I don't think this test would have caught the issue, so I don't see much advantage in adding such a test.  Even if we want to add such a test case, I think as proposed this will substantially increase the timing for "Select Into" test which might not be an acceptable test case addition especially for testing one corner case.
 
>
> Explain Analyze produces planning time and execution time even with TIMING OFF
> so not adding the same to regress tests.
>

Yeah, that makes the addition of test for this functionality difficult.  Robert, do you have any idea what kind of test would have caught this issue?


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: raw output from copy
Следующее
От: Alexander Kuleshov
Дата:
Сообщение: [PATCH] Use MemoryContextAlloc() in the MemoryContextAllocZero() and MemoryContextAllocZeroAligned()