Re: chkpass with RANDOMIZE_ALLOCATED_MEMORY

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: chkpass with RANDOMIZE_ALLOCATED_MEMORY
Дата
Msg-id CAA4eK1+vwo5-vJy9k1p08LSzMmzgYFjKjp3tir8zG0UyECS83A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: chkpass with RANDOMIZE_ALLOCATED_MEMORY  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: chkpass with RANDOMIZE_ALLOCATED_MEMORY  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Sat, Feb 14, 2015 at 10:26 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Asif Naeem <anaeem.it@gmail.com> writes:
> > It is been observed on RANDOMIZE_ALLOCATED_MEMORY enabled PG95 build that
> > chkpass is failing because of uninitialized memory and seems showing false
> > alarm.
>
> It's not a false alarm, unfortunately, because chkpass_in actually does
> give different results from one call to the next.  We could fix the aspect
> of that involving failing to zero out unused bytes (which it appears was
> introduced by sloppy replacement of strncpy with strlcpy).  But we can't
> really do anything about the dependency on random(), because that's part
> of the fundamental specification of the data type.  It was a bad idea,
> no doubt, to design the input function to do this; but we're stuck with
> it now.
>

It seems to me that fix for this issue has already been committed
(commit-id: 80986e85).  So isn't it better to mark as Committed in
CF app [1] or are you expecting anything more related to this issue?


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Stephen Frost
Дата:
Сообщение: Re: Proposal: knowing detail of config files via SQL
Следующее
От: Tom Lane
Дата:
Сообщение: Re: chkpass with RANDOMIZE_ALLOCATED_MEMORY