On Sat, Feb 24, 2024 at 5:21 AM Tristen Raab <tristen.raab@highgo.ca> wrote:
>
> I've reviewed your patch, it applies correctly and the documentation builds without any errors. As for the content of
thepatch itself, I think so far it's good but would make two modifications. I like how the patch was worded originally
whenreferring to the subscription, stating these parameters were 'in' the subscription rather than 'by' it. So I'd
proposechanging
>
> > parameters specified by the subscription. When creating the slot, ensure
>
> to
>
> > parameters specified in the subscription. When creating the slot, ensure
>
This suggestion makes sense, so I updated the patch for this and committed.
--
With Regards,
Amit Kapila.