Re: Executor code - found an instance of a WHILE that should just be an IF

Поиск
Список
Период
Сортировка
От David Rowley
Тема Re: Executor code - found an instance of a WHILE that should just be an IF
Дата
Msg-id CAApHDvq-Guz65T7V5Vctxne-L=s2LpLtvJroucW_EH83Mc=esg@mail.gmail.com
обсуждение исходный текст
Ответ на Executor code - found an instance of a WHILE that should just be an IF  (Greg Nancarrow <gregn4422@gmail.com>)
Ответы Re: Executor code - found an instance of a WHILE that should just be an IF  (David Rowley <dgrowleyml@gmail.com>)
Список pgsql-hackers
On Mon, 10 May 2021 at 21:16, Greg Nancarrow <gregn4422@gmail.com> wrote:
> During debugging I noticed some code in ExecResult() where a WHILE
> loop is being used with an unconditional RETURN at the end of the
> block (which is intentional, looking at the history of changes), but
> now there's no actual use of the loop in any way. The code should
> probably be changed to just use IF for clarity.
> I've attached a patch.

Looks like leftovers from ea15e1867.

I don't think this will affect any code generation but you are right,
it should be an "if".

David



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Antonin Houska
Дата:
Сообщение: Re: [PATCH] Full support for index LP_DEAD hint bits on standby
Следующее
От: Joe Conway
Дата:
Сообщение: Re: PG 14 release notes, first draft