On Tue, Sep 12, 2017 at 5:57 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> I have committed this patch, after a perltidy run, but the way the libz
> detection was implemented was a bit too hackish for me, so I have
> omitted that for now.
Thanks.
> I think a more robust way would be to parse
> Makefile.global, perhaps by a function in TestLib, so it can be reused
> in other tests. (Even more robust would be to write out an actual Perl
> file with configuration information somewhere, but maybe we don't need
> to go there yet.) Or maybe have the respective make variables exported
> when make check is called (could be included in the prove_check
> variable?). Anyway, some more pondering could lead to a more general
> solution.
There is always room for improvement,
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers