Also, it seems that the delta patch I sent in the last email didn't contain all the changes I had to make. It didn't contain, for example, replacing adjust_and_expand_inherited_tlist() with adjust_partition_tlist(). I guess you'll know when you rebase anyway.
Yes, I am planning to fix that once the ON CONFLICT patch is ready/committed.
Now that ON CONFLICT patch is in, here are rebased patches. The second patch is to add support for CTE (thanks Peter).
Apart from rebase, the following things are fixed/improved:
- Added test cases for column level privileges as suggested by Peter. One problem got discovered during the process. Since we expand and track source relation targetlist, the exiting code was demanding SELECT privileges on all attributes, even though MERGE is only referencing a few attributes on which the user has privilege. Fixed that by disassociating expansion from the actual referencing.
- Added a test case for RLS where SELECT policy actually hides some rows, as suggested by Stephen in the past
- Added check to compare result relation's and merge target relation's OIDs, as suggested by Robert. Simon thinks it's not necessary given that we now scan catalog using MVCC snapshot. So will leave it to his discretion when he takes it up for commit
- Improved explanation regarding why we need a second RTE for merge target relation and general cleanup/improvements in that area
I think it will be a good idea to send any further patches as add-on patches for reviewer/committer's sake. I will do that unless someone disagrees.