On Fri, Nov 4, 2011 at 15:09, Stephen Frost <sfrost@snowman.net> wrote:
> Magnus,
>
> * Magnus Hagander (magnus@hagander.net) wrote:
>> The attached patch makes the \d output for psql on a sequence show
>> which table/column owns the sequence. The table already showed the
>> dependency the other way through the default value, but going from
>> sequence back to table was not possible.
>
> Seems reasonable.
>
>> Comments/reviews?
>
> Not sure if that 'goto error_return;' handles this correctly, but it
> would seem like you're missing the possibility that a sequence isn't
> owned by any table/column..? Or that it could be depended upon by more
> than one table/column? Both of those happen and are perfectly valid
> situations for a sequence to be in..
If there is noone owning it at all, it just falls through the if/else
block and ignores it if that happens (PQntuples() returns 0).
Is there really a case for multiple sequences to own it? How would you
go about making that happen? ALTER SEQUENCE.. OWNED BY.. only takes
one table, afaics?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/