Re: [pgAdmin4]: Fix for RM #3248

Поиск
Список
Период
Сортировка
От Neel Patel
Тема Re: [pgAdmin4]: Fix for RM #3248
Дата
Msg-id CACCA4P01Sf7cq6xnTZCfRcdG0QEBp0PFPKhPtqbOqg2Od04DrA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4]: Fix for RM #3248  (Neel Patel <neel.patel@enterprisedb.com>)
Ответы Re: [pgAdmin4]: Fix for RM #3248  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Hi,

Please find updated patch after fixing the comments.
Review it and let me know for comments.

Thanks,
Neel Patel

On Thu, Apr 5, 2018 at 11:32 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Thanks Murtuza & Khushboo.
I will send updated patch.

Thanks,
Neel Patel

On Thu, Apr 5, 2018 at 11:29 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Neel,

Add below code to the top (around line no 8) in alertify.pgadmin.defaults.js file will solve the problem.

alertify.defaults.closable = false;


Thanks,
Khushboo

On Thu, Apr 5, 2018 at 11:13 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Neel,

Can we make the change in wrapper instead of changing every where?
File: ../web/pgadmin/static/js/alertify.pgadmin.defaults.js


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Apr 5, 2018 at 11:04 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi,

Please find attached patch for the fix of RM #3248 - we have modified alertify confirm dialog to modal dialog.

Do review it and let me know for comments.

Thanks,
Neel Patel




Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Neel Patel
Дата:
Сообщение: Re: [pgAdmin4]: Fix for RM #3248
Следующее
От: Neel Patel
Дата:
Сообщение: Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios