On Mon, Feb 26, 2024 at 7:27 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 1 Jul 2020, at 10:36, Daniel Gustafsson <daniel@yesql.se> wrote:
> >
> >> On 27 Mar 2020, at 11:22, Haozhou Wang <hawang@pivotal.io> wrote:
> >
> >> We rebased this patch with the newest master.
> >
> > This patch now fails to build according to Travis:
> >
> > smgr.c: In function ‘smgrtruncate’:
> > smgr.c:578:47: error: passing argument 4 of ‘smgrtruncate_hook’ makes integer from pointer without a cast
[-Werror=int-conversion]
> > (*smgrtruncate_hook)(reln, forknum, nforks, nblocks);
> > ^
> > smgr.c:578:47: note: expected ‘BlockNumber {aka unsigned int}’ but argument is of type ‘BlockNumber * {aka unsigned
int*}’
> >
> >
> > The warning is also present in the Windows build:
> >
> > src/backend/storage/smgr/smgr.c(578): warning C4047: 'function' : 'BlockNumber' differs in levels of indirection
from'BlockNumber *' [C:\projects\postgresql\postgres.vcxproj]
> > src/backend/storage/smgr/smgr.c(578): warning C4024: 'smgrtruncate_hook' : different types for formal and actual
parameter4 [C:\projects\postgresql\postgres.vcxproj]
> > 2 Warning(s)
> >
> > Marking the patch as Waiting for Author.
>
> As the thread has stalled and the above compilation issue hasn't been
> addressed, I'm marking this entry Returned with Feedback. Feel free to open a
> new entry when there is a fixed patch.
Hi,
Looks that many hackers are happy with the original patch except that
the original patch needs a simple rebase, though it has been 3 years.
Shall we push forward this patch so that it can benefit extensions not
only diskquota?
The attachment is a rebased version of the original patch.
>
> cheers ./daniel
>
>
>