Re: Using defines for protocol characters

Поиск
Список
Период
Сортировка
От Dave Cramer
Тема Re: Using defines for protocol characters
Дата
Msg-id CADK3HHJ2U_B0Rfdaj=0CMuTO1P-0NEmoAeYqU0XnkiHnqtg1dw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Using defines for protocol characters  (Peter Eisentraut <peter@eisentraut.org>)
Ответы Re: Using defines for protocol characters  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers


On Wed, 9 Aug 2023 at 09:19, Peter Eisentraut <peter@eisentraut.org> wrote:
1. As was discussed, these definitions should go into
src/include/libpq/pqcomm.h, not a new file.

I'm ambivalent, this is very easy to do.  

2. I would prefer an underscore after PgMsg, like PqMsg_DescribeRequest,
so it's easier to visually locate the start of the actual message name.

3. IMO, the names of the protocol messages in protocol.sgml are
canonical.  Your patch appends "Request" and "Response" in cases where
that is not part of the actual name.  Also, some messages are documented
to go both ways, so this separation doesn't make sense strictly
speaking.  Please use the names as in protocol.sgml without augmenting them.


I've changed this a number of times. I do not mind changing it again, but can we reach a consensus ?

Dave 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tomas Vondra
Дата:
Сообщение: Re: Use of additional index columns in rows filtering
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Adding a pg_servername() function