Re: Fix for REFRESH MATERIALIZED VIEW ownership error message

Поиск
Список
Период
Сортировка
От Dave Cramer
Тема Re: Fix for REFRESH MATERIALIZED VIEW ownership error message
Дата
Msg-id CADK3HHLQX7NPnXa_E721wJYKtJXpJ-skbUkToZFDwROMx+4iZQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Fix for REFRESH MATERIALIZED VIEW ownership error message  ("Jonathan S. Katz" <jkatz@postgresql.org>)
Ответы Re: Fix for REFRESH MATERIALIZED VIEW ownership error message  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Дерево обсуждения



On Sat, 18 Aug 2018 at 17:30, Jonathan S. Katz <jkatz@postgresql.org> wrote:

On Aug 18, 2018, at 5:26 PM, David G. Johnston <david.g.johnston@gmail.com> wrote:

On Saturday, August 18, 2018, Jonathan S. Katz <jkatz@postgresql.org> wrote:
It’s cosmetic, but it’s a cosmetic bug: it incorrectly tells the user that they
must be the owner of the “relational” when in reality it’s the materialized view.

Materialized views are a type of relation so it is not wrong, just one of many instances where we generalize to "relation" based in implementation details ins team of being explicit about which type of relation is being affected.

So why bother having the error message in the code at all then ? Clearly it was the intent of the author to use this language, unfortunately there was no test to prove that it works. 

This is a simple fix why push back ? Additionally it clarifies exactly what the problem is for the user as Jonathan points out.

Dave

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Jonathan S. Katz"
Дата:
Сообщение: Re: Fix for REFRESH MATERIALIZED VIEW ownership error message
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Fix for REFRESH MATERIALIZED VIEW ownership error message