Re: \if, \elseif, \else, \endif (was Re: PSQL commands:\quit_if, \quit_unless)

Поиск
Список
Период
Сортировка
От Corey Huinker
Тема Re: \if, \elseif, \else, \endif (was Re: PSQL commands:\quit_if, \quit_unless)
Дата
Msg-id CADkLM=cbF9yLTeU6T_sMxrrpZhxQH_Y+bNXdOFiGn8oVXjBngg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: \if, \elseif, \else, \endif (was Re: PSQL commands:\quit_if, \quit_unless)  (Fabien COELHO <coelho@cri.ensmp.fr>)
Ответы Re: \if, \elseif, \else, \endif (was Re: PSQL commands:\quit_if, \quit_unless)  (Fabien COELHO <coelho@cri.ensmp.fr>)
Список pgsql-hackers
New Patch v29: Now with less coverage!
(same as v28 minus the psql-on-error-stop.sql and associated changes)
Fabien raises some good points about if/then being a tremendous tool for enhancing other existing regression tests.


On Wed, Mar 29, 2017 at 2:16 PM, Fabien COELHO <coelho@cri.ensmp.fr> wrote:

Hello Tom,

If someone were to put together a TAP test suite that covered all that
and made for a meaningful improvement in psql's altogether-miserable
code coverage report[1], I would think that that would be a useful
expenditure of buildfarm time.

Ok, this is an interesting point.

What I'm objecting to is paying the overhead for such a suite in order to test just this one thing.

Well, it should start somewhere. Once something is running it is easier to add more tests.

think that that passes the bang-for-buck test; or in other words, this
isn't the place I would start if I were creating a TAP suite for psql.

Sure, I would not have started with that either.

Note that from this patch point of view, it is somehow logical to start testing a given feature when this very feature is being developed...

The summary is that we agree that psql test coverage is abysmal, but you do not want to bootstrap a better test infrastructure for this particular and rather special new feature. Ok.

Maybe Corey can submit another patch with the exit 3 test removed.

--
Fabien.

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: PG_GETARG_GISTENTRY?
Следующее
От: Dave Page
Дата:
Сообщение: Re: Schedule and Release Management Team for PG10