Re: [pgAdmin4][Patch]: Minor JS Fix

Поиск
Список
Период
Сортировка
От Joao De Almeida Pereira
Тема Re: [pgAdmin4][Patch]: Minor JS Fix
Дата
Msg-id CAE+jja=qOmqMJ2EGfpZ0WBFPkZYMb8Q_5WyoX7jiG60f+EMzXg@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][Patch]: Minor JS Fix  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi,
The code looks fine, all tests pass and linter.

Once again, not to sound like a broken record, we could have done some much more to improve our code base....
Why didn't we extract that function into a more testable place?

In order for the code to become more clean and modular, we should try to always write tests whenever we make changes to the code, even if that means extracting a small portion (ie. the onLoad function)

Thanks
Victoria & Joao

On Tue, May 15, 2018 at 12:44 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached monir patch to fix the JS issue.

Thanks,
Khushboo

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Aditya Toshniwal
Дата:
Сообщение: Re: [pgAdmin4][Patch] Feature #3270 Add support for runningregression tests against Firefox
Следующее
От: Joao De Almeida Pereira
Дата:
Сообщение: Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working inversion 2.1