Re: comments in hash_alloc_buckets

Поиск
Список
Период
Сортировка
От Ashutosh Sharma
Тема Re: comments in hash_alloc_buckets
Дата
Msg-id CAE9k0Pnu1sYRazGZaGHmMBQh7co5=cbKpRUB1tMiaDyYybpT5A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: comments in hash_alloc_buckets  (Amit Kapila <amit.kapila16@gmail.com>)
Список pgsql-hackers
>> While working on - [1], I realised that the following comments in
>> _hash_alloc_buckets() needs to be corrected.
>>
>>     /*
>>      * Initialize the freed overflow page.  Just zeroing the page won't work,
>>      * See _hash_freeovflpage for similar usage.
>>      */
>>     _hash_pageinit(page, BLCKSZ);
>>
>> Attached is the patch that corrects above comment. Thanks.
>>
>
> - * Initialize the freed overflow page.  Just zeroing the page won't work,
> + * Initialize the last page in hash index.
>
> I think saying ".. last page in hash index" sounds slightly awkward as
> this is the last page for current split point, how about just
> "Initialize the page. ..."

Yes, I mean just adding "Initialize the page. ..." looks more simple
and correct. Attached is the patch with similar comment.

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ashutosh Sharma
Дата:
Сообщение: Re: Add pgstathashindex() to get hash index table statistics.
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Patch: Write Amplification Reduction Method (WARM)