Re: Cleanup: Duplicated, misplaced comment in HeapScanDescData

Поиск
Список
Период
Сортировка
От Matthias van de Meent
Тема Re: Cleanup: Duplicated, misplaced comment in HeapScanDescData
Дата
Msg-id CAEze2Wjc4uhYwuMnmMGEZPYzzUeakzs5=2q856yXmMYDRpzOTA@mail.gmail.com
обсуждение исходный текст
Ответ на Cleanup: Duplicated, misplaced comment in HeapScanDescData  (Matthias van de Meent <boekewurm+postgres@gmail.com>)
Ответы Re: Cleanup: Duplicated, misplaced comment in HeapScanDescData  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
On Mon, 21 Nov 2022 at 12:12, Matthias van de Meent
<boekewurm+postgres@gmail.com> wrote:
>
> Hi,
>
> I noticed that the comment on/beneath rs_numblocks in HeapScanDescData
> is duplicated above rs_strategy. I don't know if there should have
> been a different comment above rs_strategy, but the current one is
> definitely out of place, so I propose to remove it as per attached.
>
> The comment was duplicated in c2fe139c20 with the update to the table
> scan APIs, which was first seen in PostgreSQL 11.

I made a mistake in determining this version number; it was PostgreSQL
12 where this commit was first included. Attached is the same patch
with the description updated accordingly.

Kind regards,

Matthias van de Meent

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ashutosh Bapat
Дата:
Сообщение: Re: Catalog_xmin is not advanced when a logical slot is lost
Следующее
От: Ashutosh Bapat
Дата:
Сообщение: Re: Logical Replication Custom Column Expression