Re: [PATCH] Optimize json_lex_string by batching character copying

Поиск
Список
Период
Сортировка
От John Naylor
Тема Re: [PATCH] Optimize json_lex_string by batching character copying
Дата
Msg-id CAFBsxsEcr5H8ydKR66VZeJo8buwScOsHX71z5KVcdvmx=YDC9g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Optimize json_lex_string by batching character copying  (John Naylor <john.naylor@enterprisedb.com>)
Ответы Re: [PATCH] Optimize json_lex_string by batching character copying  (Nathan Bossart <nathandbossart@gmail.com>)
Список pgsql-hackers
On Tue, Aug 23, 2022 at 1:03 PM John Naylor
<john.naylor@enterprisedb.com> wrote:
>
> LGTM overall. My plan is to split out the json piece, adding tests for
> that, and commit the infrastructure for it fairly soon.

Here's the final piece. I debated how many tests to add and decided it
was probably enough to add one each for checking quotes and
backslashes in the fast path. There is one cosmetic change in the
code: Before, the vectorized less-equal check compared to 0x1F, but
the byte-wise path did so with < 32. I made them both "less-equal 31"
for consistency. I'll commit this by the end of the week unless anyone
has a better idea about testing.

-- 
John Naylor
EDB: http://www.enterprisedb.com

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Richard Guo
Дата:
Сообщение: Re: Stack overflow issue
Следующее
От: Nathan Bossart
Дата:
Сообщение: Re: effective_multixact_freeze_max_age issue