On Mon, Feb 20, 2023 at 10:17 PM Tom Lane <
tgl@sss.pgh.pa.us> wrote:
>
> John Naylor <
john.naylor@postgresql.org> writes:
> > Add assert checking to pg_leftmost_one_pos32() and friends
>
> I can see that this was worth writing for testing purposes, but
> is it really worth carrying permanently? Even in a debug build,
> the ratio of cycles expended to chances of finding a problem seems
> mighty poor, and you've done a lot of damage to the readability
> of these functions too.
That's a fair point, and it's doubtful we'll need to add another platform anytime soon. I'll work on removing the asserts.