Can you send me the error message? Unfortunately there is a problem with my machine right now I am unable to investigate it myself, I am very sorry for the inconvenience.
We have tried a lot to figure out the issue but didn't find the actual cause. Can you please figure out and send the patch asap, I'll have to create candidate build tomorrow.
On Mon, Aug 19, 2019 at 1:22 PM Yosry Muhammad <yosrym93@gmail.com> wrote:
Hi Akshay,
I am sorry I do not have access to my machine right now. I will try to work on it (and the JS patch) once I get the chance to.
Test cases are failing on our build machines. When I reviewed your patch I have run test cases with paramaster "--pkg tools.sqleditor.tests" on multiple database servers and every time test case has been passed.
But on build machines we run test cases with parameter "--pkg all--exclude feature_tests" on multiple database server and it fails for second server onwards. I have also tried the same and it is failing on my machine too.
I am debugging the code why it is getting failed, but if you found any solution please send the patch asap.
On Sat, Aug 17, 2019 at 6:22 PM Yosry Muhammad <yosrym93@gmail.com> wrote:
Hi Hackers,
Please find attached a patch including new python test that checks the transaction status after executing queries and saving data when auto-commit is on/off. It also includes some refactoring of previously written python tests.