Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls anddefault values in the d

Поиск
Список
Период
Сортировка
От Harshal Dhumal
Тема Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls anddefault values in the d
Дата
Msg-id CAFiP3vz0Gxnj9oexauxkVttZx5_su2PqEXnqN1OPKTgB_mOT-g@mail.gmail.com
обсуждение исходный текст
Ответ на [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls and default values in thed  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls anddefault values in the d  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
Hi,

Below code snippet from above commit assumes that we have to disable last row after saving.

@@ -2320,6 +2340,10 @@ define(
                       grid.setSelectedRows([]);
                     }
 
+                    // Add last row(new row) to keep track of it
+                    if (is_added) {
+                      self.rows_to_disable.push(grid.getDataLength()-1);
+                    }

 However this is not the case all the time

For e.g 
Table has some data already and If user adds new row (do not save) and then copy past few exiting rows (at this point  newly added row no longer remains at last position). And after saving it disable last row which is not the newly added row.



 




-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, May 12, 2017 at 3:24 PM, Dave Page <dpage@pgadmin.org> wrote:
Improve handling of nulls and default values in the data editor. Fixes #2257

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4f9628ed436de53b1ab1a06b123755a86a8f2288
Author: Surinder Kumar <surinder.kumar@enterprisedb.com>

Modified Files
--------------
.../tables/templates/column/sql/9.2_plus/nodes.sql |  3 +-
.../tables/templates/column/sql/default/nodes.sql  |  3 +-
web/pgadmin/static/css/pgadmin.css                 |  2 +-
.../static/js/slickgrid/slick.pgadmin.editors.js   | 39 +++++++++++++++---
.../js/slickgrid/slick.pgadmin.formatters.js       | 46 ++++++++++++++++------
web/pgadmin/tools/sqleditor/__init__.py            | 25 +++++++++++-
web/pgadmin/tools/sqleditor/command.py             | 30 +++++++++++++-
.../tools/sqleditor/static/css/sqleditor.css       | 12 +++++-
.../sqleditor/templates/sqleditor/js/sqleditor.js  | 28 ++++++++++++-
9 files changed, 163 insertions(+), 25 deletions(-)


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of menuvisibility when node is hidden
Следующее
От: Dave Page
Дата:
Сообщение: Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls anddefault values in the d