On Sat, 29 Jun 2024 at 01:13, Thomas Munro <thomas.munro@gmail.com> wrote:
>
> On Sat, Jun 29, 2024 at 1:10 AM Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> > I need to sign in to github to add my review comments. So those who do not have a github account can not use it for
review.But I don't think that can be fixed. We need a way to know who left review comments.
>
> I don't think Jelte was talking about moving review discussion to
> Github, just providing a link to *view* the patches there.
Totally correct. And I realize now I should have called that out
explicitly in the initial email.
While I personally would love to be able to read & write comments on a
Github PR, integrating that with the mailing list in a way that the
community is happy with as a whole is no small task (both technically
and politically).
So (for now) I took the easy way out and sidestepped all those
difficulties, by making the github branches of the cfbot (which we
already had) a bit more user friendly as a way to access patches in a
read-only way.
> Now I'm
> wondering if there is a way to disable comments on commits in the
> postgresql-cfbot GH account. I guess they'd be lost after 48 hours
> anyway when the branch gets force-pushed and commit hash changes? I
> don't want people to start posting comments there that no one is
> looking at.
It seems you can disable them for 6 months at a time here:
https://github.com/postgresql-cfbot/postgresql/settings/interaction_limits