Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog

Поиск
Список
Период
Сортировка
От tender wang
Тема Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog
Дата
Msg-id CAHewXNkhCBfit7ufCSaRPkqcUDhO-6W5RNyQdwooqE72v3mJtQ@mail.gmail.com
обсуждение исходный текст
Ответ на [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog  (Xiaoran Wang <wxiaoran@vmware.com>)
Ответы Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog  (Xiaoran Wang <wxiaoran@vmware.com>)
Список pgsql-hackers
Дерево обсуждения


Xiaoran Wang <wxiaoran@vmware.com> 于2023年3月18日周六 15:04写道：
Hi hackers,

 In heap_create_with_catalog, the Relation new_rel_desc is created 
by RelationBuildLocalRelation, not table_open. So it's better to 
call RelationClose to release it.
Why it's better to call RelationClose? Is there a problem if using table_close()? 
What's more, the comment for it seems useless, just delete it.

Thanks!

regard, tender wang 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Add LZ4 compression in pg_dump
Следующее
От: Thomas Munro
Дата:
Сообщение: Unlinking Parallel Hash Join inner batch files sooner