Hi Akshay,
Thanks for the overall review and comments.
From the logs and screenshot shared by you, it is cleared that the debugger plugin is not installed for PG12 server, hence resulting in the failures of "xss_checks_pgadmin_debugger_test.py" test case.
Please install and re-execute the test cases.
The rest of the issues need some debugging since I have never encountered these failures while executing on Jenkins.
Thanks and regards,
Shubham Agarwal
It's big patch, and also improvement over last status.
Can we commit the patch, as to avoid any merging issues later?
Sure will do that.
Thanks
-- Ashesh
-- Thanks, Ashesh
I have run the feature test couple of times on EPAS 9.6, 11, 12 and PG 9.4, 10, 11, 12. Following are the review comments:
- Following test cases are failing every time on EPAS 12:
- Explain query with JIT stats... fails with error "no such element: Unable to locate element: {"method":"xpath","selector":"//*[contains(string(), 'JIT')]"}"
- Following test cases are failing every time on PG 12:
- History query sources and generated queries toggle...ERROR
- Tests to check if Debugger is vulnerable to XSS ... ERROR
- We have retry_count in "browser_tool_bar_test.py" and "file_manager_test.py" file. Can we make a generic function and pass the locator and retry_count it would be good.
- We have also import WebDriverWait in so many files can we have one generic class or function for all the wait events. We will pass the required timeout and the locator if possible.
Hi Hackers,
Attached is the patch for fixing the intermittent failures encountered while executing the test cases multiple times.
Please review the patch.
--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation
The Postgres Database Company
--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation
The Postgres Database Company