Re: Fix comments atop pg_get_replication_slots

Поиск
Список
Период
Сортировка
От sirisha chamarthi
Тема Re: Fix comments atop pg_get_replication_slots
Дата
Msg-id CAKrAKeVk-jbZ-KyRx-dqLnzB5SQr0A=1pdFEz4MdfschwCiQ0Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Fix comments atop pg_get_replication_slots  (Amit Kapila <amit.kapila16@gmail.com>)
Ответы Re: Fix comments atop pg_get_replication_slots  (Amit Kapila <amit.kapila16@gmail.com>)
Список pgsql-hackers
Amit, thanks for looking into this!

On Sun, Nov 20, 2022 at 11:38 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Mon, Nov 21, 2022 at 12:45 PM sirisha chamarthi
<sirichamarthi22@gmail.com> wrote:
>
> Hi Hackers,
>
> The comments atop seem to indicate that it is only showing active replication slots. The comment is ambiguous as it also shows all the slots including lost and inactive slots. Attached a small patch to fix it.
>

I agree that it is a bit confusing. How about "SQL SRF showing all
replication slots that currently exist on the database cluster"?

Looks good to me. Attached a patch for the same.
 

--
With Regards,
Amit Kapila.
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Simon Riggs
Дата:
Сообщение: Re: Reducing power consumption on idle servers
Следующее
От: Chris Travers
Дата:
Сообщение: Re: Add 64-bit XIDs into PostgreSQL 15