On Sat, May 30, 2015 at 3:12 PM, Peter Geoghegan <pg@heroku.com> wrote:
> Debugging this allowed me to come up with a significantly simplified
> approach. Attached is a new version of the original fix. Details are
> in commit message -- there is no actual need to have
> search_indexed_tlist_for_var() care about Vars being resjunk in a
> special way, which is a good thing.
It feels wrong to not have the additional, paranoid IsVar() check
within pull_var_targetlist_clause() check added in most recent
revision, even though it should not be necessary. Attached delta patch
adds this check.
I need to stop working on weekends...
--
Peter Geoghegan