Hi Akshay,
Everything seems to be fine. I have a few suggestions:
1) In class CompoundTriggerModule (python), "A module class for Trigger" should be "A module class for Compound Trigger"
2) We need to send a pull request to Code Mirror to highlight to make show the word - COMPOUND as a keyword.
3) Add the trigger name after END of the compound trigger definition. eg END <cp trig>;
4) Table SQL tab should show compound triggers.
5) Compound trigger disabled icon is cut. @Chethana Kumar - the icon need to be revisited. 6) In edit, SQL generated (msql) is having minor spacing issues on the "FOR ..." line. Eg:
CREATE OR REPLACE TRIGGER comptrig
FOR INSERT OR DELETE OR UPDATE
You can commit the code once fixed.
Thanks Akshay. I want to do a pass over the docs before this is committed. Otherwise, I don't see any obvious issues - however, it's a pretty big patch, so can you have one of the others on the team do a review/test as well please?
Hi Hackers
I have added the support of Compound Trigger in pgAdmin4 for EPAS v12 and above. I have created a new collection node named "Compound Triggers" under the Tables node. API and RE-SQL test cases are covered and documentation is done.
Please review the attached patch.
--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
--
--
Thanks and Regards,Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
--
Thanks and Regards,Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"