On Thu, Aug 24, 2023 at 10:05 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
On 24/08/2023 15:48, Thomas Munro wrote: > LGTM. I vaguely recall thinking that it might be better to keep > EXEC_BACKEND and !EXEC_BACKEND working the same which might be why I > didn't try this one, but it looks fine with the comment to explain, as > you have it. (It's a shame we can't use O_CLOFORK.)
Yeah, O_CLOFORK would be nice..
Committed, thanks!
Since this commit, I'm getting a lot (63 per restart) of messages:
LOG: could not close client or listen socket: Bad file descriptor
All I have to do to get the message is turn logging_collector = on and restart.
The close failure condition existed before the commit, it just wasn't logged before. So, did the extra logging added here just uncover a pre-existing bug?
The LOG message is sent to the terminal, not to the log file.